mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.
Date Thu, 02 Nov 2017 22:25:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63520/#review189976
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-tidy/entrypoint.sh
Lines 33 (patched)
<https://reviews.apache.org/r/63520/#comment267229>

    Let's add a comment here that we do this to generate `3rdparty/stout/tests/protobuf_tests.pb.h`
(in addition to the commit message).
    
    Ideally we would just generate that file instead of compiling and linking the complete
test executable, but I wasn't able to get that work when generating make build files like
we do here.


- Benjamin Bannier


On Nov. 2, 2017, 7:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63520/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds `stout-tests` as a build target for `mesos-tidy`
> in order to force the generation of `protobuf-tests.pb.h`.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c 
> 
> 
> Diff: https://reviews.apache.org/r/63520/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message