mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63499: Fixed the unit test that broke Windows build.
Date Thu, 02 Nov 2017 11:41:30 GMT


> On Nov. 2, 2017, 5:51 a.m., Andrew Schwartzmeyer wrote:
> > Who is hausdorff and why is this their TODO?
> 
> Qian Zhang wrote:
>     hausdorff is Alex Clemmer's Github account, I think he was working on Windows porting.
Actually I found this comment [here](https://github.com/apache/mesos/blob/1.4.0/src/tests/command_executor_tests.cpp#L226),
we had the similar issue when using kill policy helper in command executor test, I think it's
better to keep this comment unchanged since it's originally from hausdorff.

MESOS-6698 is resolved. We probably should reopen it or file a new ticket and update the comment.
Or maybe make kill helpers work on windows ; )?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189882
-----------------------------------------------------------


On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 8:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> -------
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message