mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.
Date Wed, 01 Nov 2017 20:54:30 GMT


> On Oct. 31, 2017, 3:43 p.m., Benjamin Mahler wrote:
> > src/tests/master_slave_reconciliation_tests.cpp
> > Lines 721 (patched)
> > <https://reviews.apache.org/r/63353/diff/1/?file=1870005#file1870005line721>
> >
> >     TaskExecutorIds?

Renamed in RR 63474.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189761
-----------------------------------------------------------


On Nov. 1, 2017, 1:53 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 1:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/2/
> 
> 
> Testing
> -------
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, but passes
with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message