Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8848597347520653671=="
MIME-Version: 1.0
Subject: Re: Review Request 63105: Removed TODOs from storage operation 'apply'
 handlers.
From: Jie Yu <yujie.jay@gmail.com>
To: Benjamin Bannier <bbannier@apache.org>, Jie Yu <yujie.jay@gmail.com>
Cc: Chun-Hung Hsiao <chhsiao@mesosphere.io>, Jan Schlicht <jan@mesosphere.io>,
 mesos <reviews@mesos.apache.org>
Date: Mon, 30 Oct 2017 14:34:01 -0000
Message-ID: <20171030143401.50230.51835@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Jie Yu <noreply@reviews.apache.org>
References: <20171030102528.50427.88977@reviews-vm2.apache.org>
In-Reply-To: <20171030102528.50427.88977@reviews-vm2.apache.org>
Reply-To: Jie Yu <yujie.jay@gmail.com>
archived-at: Mon, 30 Oct 2017 14:34:06 -0000

--===============8848597347520653671==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 30, 2017, 10:25 a.m., Benjamin Bannier wrote:
> > src/common/resources.cpp
> > Lines 1765-1779 (original), 1765-1783 (patched)
> > <https://reviews.apache.org/r/63105/diff/2/?file=1864832#file1864832line1765>
> >
> >     Can we collapse these now for readabilty?, e.g.,
> >     
> >         case Offer::Operation::CREATE_VOLUME:
> >         case Offer::Operation::DESTROY_VOLUME:
> >         case Offer::Operation::CREATE_BLOCK:
> >         case Offer::Operation::DESTROY_BLOCK: {
> >           // These operations do not alter the offered resources.
> >           break;
> >         }

This will be changed in the following patches.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63105/#review189557
-----------------------------------------------------------


On Oct. 20, 2017, 12:53 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63105/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2017, 12:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7594
>     https://issues.apache.org/jira/browse/MESOS-7594
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These operations don't alter the offered resources immediately.
> Only after operation feedback has been received, resources might
> be altered. But this will be handled in a different code path.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 7ee4dae1389e037531aec533a3d235ee06443ea8 
> 
> 
> Diff: https://reviews.apache.org/r/63105/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


--===============8848597347520653671==--