Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9D0D6200D27 for ; Wed, 25 Oct 2017 22:48:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9B69C160BF2; Wed, 25 Oct 2017 20:48:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E01551609CE for ; Wed, 25 Oct 2017 22:48:34 +0200 (CEST) Received: (qmail 94532 invoked by uid 500); 25 Oct 2017 20:48:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94521 invoked by uid 99); 25 Oct 2017 20:48:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 20:48:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0D7DA1807B1; Wed, 25 Oct 2017 20:48:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FJPSudY2WMPl; Wed, 25 Oct 2017 20:48:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D352E5F666; Wed, 25 Oct 2017 20:48:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 32BECE0012; Wed, 25 Oct 2017 20:48:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A6551C401D9; Wed, 25 Oct 2017 20:48:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8605850949504620335==" MIME-Version: 1.0 Subject: Re: Review Request 63304: Removed Flag Tests TODO comments. From: Andrew Schwartzmeyer To: Andrew Schwartzmeyer Cc: Raluca Miclea , mesos Date: Wed, 25 Oct 2017 20:48:28 -0000 Message-ID: <20171025204828.2646.18273@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63304/ X-Sender: Andrew Schwartzmeyer References: <20171025203506.2645.45273@reviews-vm2.apache.org> In-Reply-To: <20171025203506.2645.45273@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos archived-at: Wed, 25 Oct 2017 20:48:35 -0000 --===============8605850949504620335== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63304/#review189248 ----------------------------------------------------------- This review request should squashed into 63239 (as in, amend the commit used to post 63239, and then re-run the post-reviews script, it will ask to update the existing review, then discard this review). - Andrew Schwartzmeyer On Oct. 25, 2017, 1:35 p.m., Raluca Miclea wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63304/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 1:35 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-3437 > https://issues.apache.org/jira/browse/MESOS-3437 > > > Repository: mesos > > > Description > ------- > > Removed Flag Tests TODO comments. > > > Diffs > ----- > > 3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 > > > Diff: https://reviews.apache.org/r/63304/diff/2/ > > > Testing > ------- > > > Thanks, > > Raluca Miclea > > --===============8605850949504620335==--