Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1558593597820690915=="
MIME-Version: 1.0
Subject: Re: Review Request 63213: Added mount propagation support for
 HOST_PATH volumes.
From: Mesos Reviewbot Windows <reviews@mesos.apache.org>
To: Joseph Wu <joseph@mesosphere.io>, Gilbert Song <songzihao1990@gmail.com>,
 James Peach <jpeach@apache.org>
Cc: Mesos Reviewbot Windows <reviews@mesos.apache.org>,
 mesos <reviews@mesos.apache.org>, Jie Yu <yujie.jay@gmail.com>
Date: Mon, 23 Oct 2017 09:58:55 -0000
Message-ID: <20171023095855.11167.76871@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Mesos Reviewbot Windows <noreply@reviews.apache.org>
References: <20171023044603.58298.81400@reviews-vm2.apache.org>
In-Reply-To: <20171023044603.58298.81400@reviews-vm2.apache.org>
Reply-To: Mesos Reviewbot Windows <reviews@mesos.apache.org>
archived-at: Mon, 23 Oct 2017 09:59:02 -0000

--===============1558593597820690915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63213/#review188930
-----------------------------------------------------------


FAIL: Failed to apply the dependent review: 63211.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63211`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63213

Relevant logs:

- [apply-review-63211-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63213/logs/apply-review-63211-stdout.log):

```
error: patch failed: src/slave/containerizer/mesos/isolators/filesystem/linux.cpp:350
error: src/slave/containerizer/mesos/isolators/filesystem/linux.cpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/launch.cpp:240
error: src/slave/containerizer/mesos/launch.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 23, 2017, 4:46 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63213/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 4:46 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows a container to declare a host path volume such that the
> mounts under that volume can be propagated in both directions.
> Previously, all volume mounts are default to use host to container
> propagation mode.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 859fdff4d9a0604bc506b08af79075084ae23466 
>   include/mesos/v1/mesos.proto cfd4abd3af1d8c9fbd31659161eada9ec9f92282 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302 
>   src/slave/containerizer/mesos/launch.cpp 49f11f1d586672bb46f6eccabcfda9321cc3c607 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 1d006727e5bf76cc659e862cb64fe3facd608c8c 
>   src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954 
> 
> 
> Diff: https://reviews.apache.org/r/63213/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


--===============1558593597820690915==--