Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58A5B200D49 for ; Fri, 20 Oct 2017 07:30:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5704B1609EE; Fri, 20 Oct 2017 05:30:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A3BC3160BEC for ; Fri, 20 Oct 2017 07:30:31 +0200 (CEST) Received: (qmail 13551 invoked by uid 500); 20 Oct 2017 05:30:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 3607 invoked by uid 99); 20 Oct 2017 05:23:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 05:23:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 14A941A053A; Fri, 20 Oct 2017 05:23:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Wc6kS73LUD2h; Fri, 20 Oct 2017 05:23:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 664CF5FBB0; Fri, 20 Oct 2017 05:23:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BCCE4E099A; Fri, 20 Oct 2017 05:23:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CA404C417D4; Fri, 20 Oct 2017 05:23:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0762889743397609833==" MIME-Version: 1.0 Subject: Re: Review Request 62003: Added `network/ports` isolator nested container tests. From: Mesos Reviewbot Windows To: Qian Zhang , Jiang Yan Xu Cc: Mesos Reviewbot Windows , James Peach , mesos Date: Fri, 20 Oct 2017 05:23:19 -0000 Message-ID: <20171020052319.56753.19313@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62003/ X-Sender: Mesos Reviewbot Windows References: <20171017191526.5693.2249@reviews-vm2.apache.org> In-Reply-To: <20171017191526.5693.2249@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/ports_isolator_tests.cpp Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos archived-at: Fri, 20 Oct 2017 05:30:32 -0000 --===============0762889743397609833== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188814 ----------------------------------------------------------- FAIL: Failed to apply the dependent review: 60491. Failed command: `python.exe .\support\apply-reviews.py -n -r 60491` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62003 Relevant logs: - [apply-review-60491-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62003/logs/apply-review-60491-stdout.log): ``` error: patch failed: src/linux/routing/diagnosis/diagnosis.hpp:60 error: src/linux/routing/diagnosis/diagnosis.hpp: patch does not apply error: patch failed: src/linux/routing/diagnosis/diagnosis.cpp:67 error: src/linux/routing/diagnosis/diagnosis.cpp: patch does not apply ``` - Mesos Reviewbot Windows On Oct. 17, 2017, 7:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 7:15 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62003/diff/8/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > > --===============0762889743397609833==--