Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7092200D20 for ; Tue, 17 Oct 2017 15:45:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D3BC21609EB; Tue, 17 Oct 2017 13:45:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 271D31609DE for ; Tue, 17 Oct 2017 15:45:04 +0200 (CEST) Received: (qmail 54193 invoked by uid 500); 17 Oct 2017 13:45:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54182 invoked by uid 99); 17 Oct 2017 13:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 13:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 51A51180647; Tue, 17 Oct 2017 13:45:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id C850uYH_taa6; Tue, 17 Oct 2017 13:45:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 67E055F569; Tue, 17 Oct 2017 13:45:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0F9E7E00B3; Tue, 17 Oct 2017 13:45:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 76C92C413C3; Tue, 17 Oct 2017 13:44:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8647324258405796701==" MIME-Version: 1.0 Subject: Review Request 63074: Changed return type of `ns::getns()` from `Try` to `Result`. From: Andrei Budnik To: Jie Yu , Kevin Klues , Alexander Rukletsov Cc: Andrei Budnik , mesos Date: Tue, 17 Oct 2017 13:44:58 -0000 Message-ID: <20171017134458.5693.53571@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Budnik X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63074/ X-Sender: Andrei Budnik Reply-To: Andrei Budnik X-ReviewRequest-Repository: mesos archived-at: Tue, 17 Oct 2017 13:45:05 -0000 --===============8647324258405796701== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63074/ ----------------------------------------------------------- Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. Bugs: MESOS-7504 https://issues.apache.org/jira/browse/MESOS-7504 Repository: mesos Description ------- Previously, `getns` checked existence of process's pid before trying to `stat` the namespace file. If the pid didn't exist, then it returned a failure. Now, `getns` checks existence of process's pid only on failure of `stat` for the namespace file. If the pid doesn't exist, then it returns `None()`. Diffs ----- src/linux/ns.hpp e96116343b132ff4aae36c7b3c1b0e99c41246af src/slave/containerizer/mesos/utils.cpp ec6d6c79b0f93cabe880cd697094c20e999af4d1 src/tests/containerizer/isolator_tests.cpp 5072bafabc0e37bc756588b88e4d9f8a8c84d337 src/tests/containerizer/ns_tests.cpp 2e28139d241e5e37c8fd0f8b4531c3d271727c8d Diff: https://reviews.apache.org/r/63074/diff/1/ Testing ------- make check Thanks, Andrei Budnik --===============8647324258405796701==--