Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8533A200D19 for ; Fri, 6 Oct 2017 23:54:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 83A751609E1; Fri, 6 Oct 2017 21:54:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CA22B1609D0 for ; Fri, 6 Oct 2017 23:54:58 +0200 (CEST) Received: (qmail 52661 invoked by uid 500); 6 Oct 2017 21:54:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52650 invoked by uid 99); 6 Oct 2017 21:54:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2017 21:54:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EBBCAD1627; Fri, 6 Oct 2017 21:54:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 12Rdbim7aLCj; Fri, 6 Oct 2017 21:54:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 56BB35F1BA; Fri, 6 Oct 2017 21:54:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 074E1E00A7; Fri, 6 Oct 2017 21:54:55 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E7D21C4038A; Fri, 6 Oct 2017 21:54:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8854767970909441337==" MIME-Version: 1.0 Subject: Re: Review Request 62818: Removed a redundant equality check for Mount disk source. From: Joseph Wu To: Benjamin Bannier , Joseph Wu Cc: Jie Yu , mesos Date: Fri, 06 Oct 2017 21:54:54 -0000 Message-ID: <20171006215454.21302.1641@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62818/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20171006214144.21267.90884@reviews-vm2.apache.org> In-Reply-To: <20171006214144.21267.90884@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos archived-at: Fri, 06 Oct 2017 21:54:59 -0000 --===============8854767970909441337== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62818/#review187307 ----------------------------------------------------------- Ship it! LGTM. - Joseph Wu On Oct. 6, 2017, 2:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62818/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2017, 2:41 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Removed a redundant equality check for Mount disk source. > > > Diffs > ----- > > src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 > > > Diff: https://reviews.apache.org/r/62818/diff/1/ > > > Testing > ------- > > > Thanks, > > Jie Yu > > --===============8854767970909441337==--