Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B7F4200D14 for ; Tue, 3 Oct 2017 19:14:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 59E6F1609DE; Tue, 3 Oct 2017 17:14:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A01671609BD for ; Tue, 3 Oct 2017 19:14:00 +0200 (CEST) Received: (qmail 612 invoked by uid 500); 3 Oct 2017 17:13:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 601 invoked by uid 99); 3 Oct 2017 17:13:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2017 17:13:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C61D71A0CF8; Tue, 3 Oct 2017 17:13:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id auI4ddk3jK-x; Tue, 3 Oct 2017 17:13:57 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CDE995FCE2; Tue, 3 Oct 2017 17:13:56 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2CA5AE0044; Tue, 3 Oct 2017 17:13:56 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DA080C416CA; Tue, 3 Oct 2017 17:13:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3039134189494239478==" MIME-Version: 1.0 Subject: Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store. From: Zhitao Li To: Jie Yu , Jason Lai , Gilbert Song Cc: Zhitao Li , mesos Date: Tue, 03 Oct 2017 17:13:52 -0000 Message-ID: <20171003171352.1558.20396@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zhitao Li X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56721/ X-Sender: Zhitao Li References: <20170926181506.42294.93795@reviews-vm2.apache.org> In-Reply-To: <20170926181506.42294.93795@reviews-vm2.apache.org> Reply-To: Zhitao Li X-ReviewRequest-Repository: mesos archived-at: Tue, 03 Oct 2017 17:14:01 -0000 --===============3039134189494239478== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ ----------------------------------------------------------- (Updated Oct. 3, 2017, 5:13 p.m.) Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Changes ------- Review comments. Bugs: MESOS-4945 https://issues.apache.org/jira/browse/MESOS-4945 Repository: mesos Description ------- This includes the following changes: - add a `pruneImages()` function on the chain of relevant classes; - implement prune in docker store; - fix mock interface to keep existing tests pass. Diffs (updated) ----- src/slave/containerizer/composing.hpp 06d68eef5de7745e32f0e808f11016bcc285dd8f src/slave/containerizer/composing.cpp 587f009384f0c7ef87482686578dc822d3d5b208 src/slave/containerizer/containerizer.hpp 449bb5d0902936faae7bf9bae9c703b219aed842 src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270 src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 src/slave/containerizer/mesos/containerizer.hpp cc23b4d91be16fc95a131c09d07378b801e34d6f src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345 src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0 src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095 src/slave/containerizer/mesos/provisioner/provisioner.hpp 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e src/slave/containerizer/mesos/provisioner/provisioner.cpp 450a3b32d69d2882973a6ed4e94e169a0256056b src/slave/containerizer/mesos/provisioner/store.hpp 01ab83dca79e51b8c96d18ee65705912b0ac8324 src/slave/containerizer/mesos/provisioner/store.cpp cc5cc81e05f29bb0e11ffa13cdb8d63d4397114f src/tests/containerizer.hpp a778b8581904bacea9eec3ff50c3c009959b5dac src/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a src/tests/containerizer/mock_containerizer.hpp 0adcb01e6c12d6cc4abed1f14fa2df833ffc6569 Diff: https://reviews.apache.org/r/56721/diff/9/ Changes: https://reviews.apache.org/r/56721/diff/8-9/ Testing ------- Thanks, Zhitao Li --===============3039134189494239478==--