mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 63422: Updated os::unsetenv to clear the old environment value.
Date Mon, 30 Oct 2017 18:14:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63422/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-8140
    https://issues.apache.org/jira/browse/MESOS-8140


Repository: mesos


Description
-------

On Linux, updating the environment with unsetenv(3) does not
change the value that other processes can inspect (e.g. through
`/proc/$pid/environ`). Overwrite the existing value (if any) prior
to calling unsetenv(3) so we can know it is really gone.


Diffs
-----

  3rdparty/stout/include/stout/posix/os.hpp 8511dfd419a646df17eb687d732bb975f4c23d53 


Diff: https://reviews.apache.org/r/63422/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message