mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62878: Sent CheckpointResourcesMessage only when reregister with an old master.
Date Sun, 29 Oct 2017 15:57:07 GMT


> On Oct. 25, 2017, 12:43 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 6321-6355 (patched)
> > <https://reviews.apache.org/r/62878/diff/3/?file=1861968#file1861968line6322>
> >
> >     As discussed offline, I think it makes sense to put this block in `reconcileKnownAgent`,
as you previously suggested. I see no reason not to do it in this patch, but one of us could
follow up with another patch as well.

Yeah, I'll follow up with another patch.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/#review189089
-----------------------------------------------------------


On Oct. 17, 2017, 11:24 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62878/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8058
>     https://issues.apache.org/jira/browse/MESOS-8058
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> No need for sending checkpoint resources message to the agent if the
> master does not have state about the agent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 
> 
> 
> Diff: https://reviews.apache.org/r/62878/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message