mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63223: Fixed whitespace problems in contribution guidelines.
Date Mon, 23 Oct 2017 21:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63223/#review188986
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63223]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 23, 2017, 7:30 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63223/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 7:30 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Indentation needed to be consistently four spaces for sublists to render
> correctly, and blank linds needed to be removed for spacing to render
> correctly.
> 
> Also fixed outdated links to Getting Started for build instructions.
> 
> 
> Diffs
> -----
> 
>   docs/advanced-contribution.md 5a89227bad3f2c9845420f90ae15bcee673fefd0 
>   docs/beginner-contribution.md d82079839faa760c42123aca52ac4d5dd8b2d64b 
> 
> 
> Diff: https://reviews.apache.org/r/63223/diff/1/
> 
> 
> Testing
> -------
> 
> This fixes the rendering problems at https://mesos.apache.org/documentation/latest/advanced-contribution/
> 
> I tested by building the site locally and pendantically fixing until it rendered correctly
:P
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message