mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 63224: Fixed the flaky MasterTest.IgnoreOldAgentReregistration.
Date Mon, 23 Oct 2017 20:52:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63224/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-7726
    https://issues.apache.org/jira/browse/MESOS-7726


Repository: mesos


Description
-------

This test did not settle the clock before advancing it, which
meant that the call to delay had not yet occurred.

Also updated the test to avoid retries of the registration
message, which can lead the agent to think it is registered
after a detection event, although this shouldn't be an issue
for this test.


Diffs
-----

  src/tests/master_tests.cpp c6906a752dd70f1d76056b7199af5c27b1e6419b 


Diff: https://reviews.apache.org/r/63224/diff/1/


Testing
-------

Ran in repetition.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message