-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63107/#review188845
-----------------------------------------------------------
Bad patch!
Reviews applied: [63107, 63106, 61947, 63105, 61946, 61810, 63104, 63094, 62903, 63001]
Failed command: python support/apply-reviews.py -n -r 63107
Error:
2017-10-20 16:16:20 URL:https://reviews.apache.org/r/63107/diff/raw/ [13052/13052] -> "63107.patch"
[1]
error: patch failed: src/resource_provider/message.hpp:18
error: src/resource_provider/message.hpp: patch does not apply
error: patch failed: src/slave/slave.cpp:6644
error: src/slave/slave.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19860/console
- Mesos Reviewbot
On Oct. 20, 2017, 5:56 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63107/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 5:56 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8087
> https://issues.apache.org/jira/browse/MESOS-8087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a framework accepts an offer that contains resource provider
> resources with a storage operation (`CREATE_VOLUME`, `DESTROY_VOLUME`,
> `CREATE_BLOCK`, `DESTROY_BLOCK`), the result of this operation cannot
> be guessed and will only be known after the operation has been
> successfully applied by the resource provider.
> This patch introduces the necessary handling for such operations. The
> internal bookkeeping of available resources in the master and agent has
> been updated to update resources only after operation feedback has been
> received. This ensures that converted resources can only be offered
> after the operation was executed by a resource provider.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
> src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3
> src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521
> src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
> src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
>
>
> Diff: https://reviews.apache.org/r/63107/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
|