mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63060: Added utility functions and structures for CSI.
Date Thu, 19 Oct 2017 17:51:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/#review188712
-----------------------------------------------------------


Fix it, then Ship it!





src/csi/utils.hpp
Lines 77-78 (patched)
<https://reviews.apache.org/r/63060/#comment265726>

    The newest spec removed these. You don't need this anymore.



src/csi/utils.hpp
Lines 82-107 (patched)
<https://reviews.apache.org/r/63060/#comment265727>

    You don't need this neither. See the new spec.



src/csi/utils.cpp
Lines 25 (patched)
<https://reviews.apache.org/r/63060/#comment265728>

    Do you need `csi::` prefix?



src/csi/utils.cpp
Lines 35-36 (patched)
<https://reviews.apache.org/r/63060/#comment265731>

    nits:
    
    I would format this this way:
    ```
    return stream << strings::join(
        ".",
        version.major(),
        version.minor(),
        version.patch());
    ```


- Jie Yu


On Oct. 17, 2017, 4:50 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63060/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 4:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds some helper structures for CSI capabilities, comparison
> and output operators for `csi::Version` in the `::csi` namespace so
> `stringify()` can find it through ADL. Also, it exposes `::csi` in
> `mesos::csi` in `spec.hpp` instead of `client.hpp`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887 
>   src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238 
>   src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa 
>   src/csi/utils.hpp PRE-CREATION 
>   src/csi/utils.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63060/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message