mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.
Date Wed, 18 Oct 2017 00:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review188428
-----------------------------------------------------------



Needs a description still.


src/hdfs/hdfs.cpp
Lines 125-134 (patched)
<https://reviews.apache.org/r/60626/#comment265423>

    nit: Maybe it's just me, but this could just be `Option<int> status` and then `status.get()`
below; that's _usually_ how it's done in the codebase.


- Andrew Schwartzmeyer


On Oct. 16, 2017, 6:19 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 6:19 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Eliminated os::shell calls from HDFS for Windows compatibility.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4 
> 
> 
> Diff: https://reviews.apache.org/r/60626/diff/4/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message