mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60624: Enabled HDFS compilation and associated tests.
Date Tue, 17 Oct 2017 23:24:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review188418
-----------------------------------------------------------




src/tests/hdfs_tests.cpp
Lines 55-57 (original), 55-60 (patched)
<https://reviews.apache.org/r/60624/#comment265418>

    Nit: this comment isn't great... we do know how to handle execution permissions on Windows.
As in, the correct thing to do is not to mark it executable, as the concept simply doesn't
map.


- Andrew Schwartzmeyer


On Oct. 16, 2017, 6:18 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60624/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 6:18 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that HDFS tests are disabled for Windows due to dependence on
> 'sh' shell.
> 
> Be aware: HDFS hasn't been tested, although it should work. We will
> formally add support for HDFS at a later date, see MESOS-5460.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1a0dff3604c288d2af8ecc23f1ec73f5a350bc31 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/hdfs_tests.cpp e7154c75e663d9a98bec48be42a59b65c96f9515 
> 
> 
> Diff: https://reviews.apache.org/r/60624/diff/4/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message