mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.
Date Fri, 13 Oct 2017 20:43:48 GMT


> On Oct. 13, 2017, 12:28 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/fetcher_tests.cpp
> > Line 483 (original), 487 (patched)
> > <https://reviews.apache.org/r/60628/diff/3/?file=1852898#file1852898line487>
> >
> >     Was this URL using backslashes for some reason? This doesn't appear to be necessary.

Found it: the root of the problem was the use of `path::join(http.process->self().id, "test"));`
in the constrution of the URL. The `path` class shouldn't be used for URLs; it really should
just be `http.process->self().id + "/test"` (well, perhaps we need a `url::join` to handle
adding one and only one `/`).

But anyway, `path` is for _filesystem_ paths, not URLs. If the same problem is the cause of
the other uses of `partial_path`, then we've identified how to get rid of it.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review188003
-----------------------------------------------------------


On Oct. 11, 2017, 4:32 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60628/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 4:32 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tests for tar, gzip, and such won't be working on Windows for
> the time being. Thoughts are to provide this capability to the
> Fetcher in a cross-platform manner via a programmatic code library
> rather than Linux-specific command line tools (tar, gzip, etc).
> See MESOS-8064 for more details.
> 
> In the short term, zip and unzip will work since PowerShell can
> support that natively.
> 
> 
> Diffs
> -----
> 
>   src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b 
>   src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d 
>   src/slave/containerizer/fetcher.cpp ba5b0979aa427c5b3dbacf39661d6027da13e0d6 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/60628/diff/3/
> 
> 
> Testing
> -------
> 
> See upstream.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message