mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.
Date Fri, 13 Oct 2017 19:28:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review188003
-----------------------------------------------------------



As far as I can tell, this review is enabling the `mesos-fetcher` itself, not just the unit
tests. The title is misleading.


src/launcher/fetcher.cpp
Line 293 (original), 291 (patched)
<https://reviews.apache.org/r/60628/#comment265064>

    We should replace `path::normalize` with `path::from_uri`, which fixes the forward slashes
from a URI into backslashes, and verifies that it is indeed a file URI (i.e. starts with `file://`).
    
    The reason is that we are not performing normalization. We are instead converting to (and
here, from) a file URI.



src/slave/containerizer/fetcher.cpp
Lines 202-213 (original), 202-210 (patched)
<https://reviews.apache.org/r/60628/#comment265065>

    This logic should be refactored into `Try<string> path::from_uri`.



src/slave/containerizer/fetcher.cpp
Line 228 (original), 224 (patched)
<https://reviews.apache.org/r/60628/#comment265066>

    Doing so would then also eliminate this.



src/tests/fetcher_tests.cpp
Line 188 (original), 189 (patched)
<https://reviews.apache.org/r/60628/#comment265067>

    This probably isn't necessary, as `output_file` on `CommandInfo::URI` is just a relative
path, not a URI.



src/tests/fetcher_tests.cpp
Line 483 (original), 487 (patched)
<https://reviews.apache.org/r/60628/#comment265068>

    Was this URL using backslashes for some reason? This doesn't appear to be necessary.



src/tests/fetcher_tests.cpp
Line 531 (original), 535 (patched)
<https://reviews.apache.org/r/60628/#comment265069>

    Ditto. We should look at this closer.


- Andrew Schwartzmeyer


On Oct. 11, 2017, 4:32 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60628/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 4:32 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tests for tar, gzip, and such won't be working on Windows for
> the time being. Thoughts are to provide this capability to the
> Fetcher in a cross-platform manner via a programmatic code library
> rather than Linux-specific command line tools (tar, gzip, etc).
> See MESOS-8064 for more details.
> 
> In the short term, zip and unzip will work since PowerShell can
> support that natively.
> 
> 
> Diffs
> -----
> 
>   src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b 
>   src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d 
>   src/slave/containerizer/fetcher.cpp ba5b0979aa427c5b3dbacf39661d6027da13e0d6 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/60628/diff/3/
> 
> 
> Testing
> -------
> 
> See upstream.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message