mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62973: Optimized RepeatedPtrField to vector conversion.
Date Fri, 13 Oct 2017 19:12:03 GMT


> On Oct. 13, 2017, 7:06 p.m., Benjamin Mahler wrote:
> > Ship It!

I couldn't figure out where std::vector documents this optimization, so I avoided declaring
this was an optimization in favor of saying that this allows for optimization if the vector
implementation leverages the distance provided when the iterator is a `RandomAcesssIterator`.
Let me know if this is inaccurate!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62973/#review187998
-----------------------------------------------------------


On Oct. 13, 2017, 1:20 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62973/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 1:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `vector` can take advantage of `RepeatedPtrField` iterators implementing
> `RandomAccessIterator` concept and avoid buffer resizes, when
> constructed from range.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 808b385efb49e6e76919ed87c626b29c3e01bdaf

> 
> 
> Diff: https://reviews.apache.org/r/62973/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message