mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62929: Added documentation to CSI-related source proto fields.
Date Thu, 12 Oct 2017 15:35:08 GMT


> On Oct. 12, 2017, 4:53 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 1328 (patched)
> > <https://reviews.apache.org/r/62929/diff/2/?file=1853363#file1853363line1328>
> >
> >     need the same s/source/volume/ changes for the v1 protos

Of course, sorry. Fixed now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187797
-----------------------------------------------------------


On Oct. 12, 2017, 5:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 5:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message