mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.
Date Thu, 12 Oct 2017 15:34:58 GMT


> On Oct. 8, 2017, 3:33 a.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/uri.hpp
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/60622/diff/2/?file=1847151#file1847151line33>
> >
> >     Also, the casing comment applies to the funciton name too, plus the double "uri"
in `uri::uriFromFileName` is redundant.
> >     
> >     Could this perhaps be `uri::from_filename`?
> >     
> >     The `filename` part implies the `scheme` should be `file://` too.
> >     
> >     Maybe `uri::create` which would imply a more arbitrary "path plus scheme" to
URI mapping.

Changed this to `uri::from_path(path)`. We can refactor if we need more flexiblity down the
road.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review187349
-----------------------------------------------------------


On Oct. 11, 2017, 11:31 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60622/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 11:31 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added new stout function: path::normalize (normalize a filename),
> along with uri::from_path (generate URI from file path).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 
>   3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 
>   3rdparty/stout/include/stout/path.hpp 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 
>   3rdparty/stout/include/stout/uri.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 6e5773f1e03671de7ac007caf49edd0f1cd7aedd 
>   3rdparty/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d 
>   3rdparty/stout/tests/uri_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60622/diff/3/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message