mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 62876: Fix compile error for bundled gRPC on Debian 8 with libc-ares-dev.
Date Wed, 11 Oct 2017 20:43:35 GMT


> On Oct. 11, 2017, 8:31 p.m., Zhitao Li wrote:
> > 3rdparty/grpc-1.4.2.patch
> > Lines 34 (patched)
> > <https://reviews.apache.org/r/62876/diff/2/?file=1852086#file1852086line34>
> >
> >     trailing whitespace?

This is from the gRPC repo. I just cherry-picked the commits and use `git diff` to create
this patch. The patch might fail to apply to the gRPC bundle if we omits these spaces.
If you're having problem applying this patch, please use `support/apply-reviews.py -s` to
skip format checkings.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62876/#review187695
-----------------------------------------------------------


On Oct. 11, 2017, 12:49 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62876/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 12:49 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Zhitao Li.
> 
> 
> Bugs: MESOS-8070
>     https://issues.apache.org/jira/browse/MESOS-8070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the following commit to `3rdparty/grpc-1.4.2.patch`:
> 
> https://github.com/grpc/grpc/commit/f8b6d6f
> 
> The gRPC patch file also includes the following patches originally:
> 
> https://github.com/grpc/grpc/commit/807693b
> https://github.com/grpc/grpc/commit/43f7acf
> https://github.com/grpc/grpc/pull/11558
> https://github.com/grpc/grpc/pull/11565
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 687f52d9299bf9c6425c2ba7c35c050ff45a33cd 
>   3rdparty/grpc-1.4.2.patch bce9871bf1cadbb643325705c96d4194d17b4b73 
>   3rdparty/grpc-1.4.2.readme PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62876/diff/2/
> 
> 
> Testing
> -------
> 
> make on Debian 8 with libc-ares-dev (1.10.0) installed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message