mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 62793: Added cpplint to the list of excluded files by Python linter.
Date Tue, 10 Oct 2017 15:10:21 GMT


> On Oct. 10, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > support/mesos-style.py
> > Lines 346 (patched)
> > <https://reviews.apache.org/r/62793/diff/3/?file=1850112#file1850112line346>
> >
> >     Any reason we are not more explicit here, e.g., `r'cpplint.py'`?

The previous lines were only using basenames thus I have done the same. Does it make sense?


- Armand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187534
-----------------------------------------------------------


On Oct. 10, 2017, 9:57 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This make sure that no third party libraries are being linted.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62793/diff/3/
> 
> 
> Testing
> -------
> 
> After this commit I have modified 'support/cpplint.py' and checked that it was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message