-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review187358
-----------------------------------------------------------
Summary and description need to follow Mesos standards (past-tense, full-sentence summary,
with description in the body).
3rdparty/stout/include/stout/os/write.hpp
Lines 118 (patched)
<https://reviews.apache.org/r/60620/#comment264340>
Style (`#endif // __WINDOWS__`).
- Andrew Schwartzmeyer
On Oct. 5, 2017, 9:04 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2017, 9:04 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modify os::write to write binary files on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/write.hpp 9ff749f209e6dd6ca3695907108a029c9a2b4f05
>
>
> Diff: https://reviews.apache.org/r/60620/diff/3/
>
>
> Testing
> -------
>
> Built successfully on both Linux (with autotools and cmake) and Windows (with cmake).
>
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
>
>
> Thanks,
>
> Jeff Coffler
>
>
|