mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60625: Normalize file separation characters on Windows when building path.
Date Sun, 08 Oct 2017 03:58:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60625/#review187351
-----------------------------------------------------------




3rdparty/stout/include/stout/path.hpp
Lines 149 (patched)
<https://reviews.apache.org/r/60625/#comment264310>

    See my comment in #60622, it applies here too. Wouldn't it be nice to just drop this whole
review?



3rdparty/stout/include/stout/path.hpp
Lines 150 (patched)
<https://reviews.apache.org/r/60625/#comment264311>

    This needs to be `#endif // __WINDOWS__`.


- Andrew Schwartzmeyer


On Oct. 5, 2017, 9:05 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60625/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 9:05 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Normalize file separation characters on Windows when building path.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 
> 
> 
> Diff: https://reviews.apache.org/r/60625/diff/2/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message