mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62587: Added HTTP authenticatee interface definition.
Date Fri, 06 Oct 2017 13:42:00 GMT


> On Oct. 6, 2017, 9:56 a.m., Alexander Rojas wrote:
> > include/mesos/authentication/http/authenticatee.hpp
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/62587/diff/4/?file=1842299#file1842299line46>
> >
> >     Any reason not to make it pure virtual?

The implementation may or may not need it - e.g. basic authentication wont hold any internal
state.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187244
-----------------------------------------------------------


On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-8016
>     https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/4/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message