mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 62214: Added JavaScript linter.
Date Thu, 05 Oct 2017 13:45:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187180
-----------------------------------------------------------




support/mesos-style.py
Lines 356-361 (patched)
<https://reviews.apache.org/r/62214/#comment264088>

    This should already be handled by the `exclude_files` list and the `find_candidates()`
function in the base class. Is it necessary to duplicate this logic here?



support/mesos-style.py
Lines 364 (patched)
<https://reviews.apache.org/r/62214/#comment264089>

    I don't think this function will ever be called if len(source_paths) == 0 (meaning this
check is unnecessary). See the main() function from the base class.


- Kevin Klues


On Sept. 29, 2017, 1:28 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -----
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/5/
> 
> 
> Testing
> -------
> 
> Following this commit, I have tried to commit a change on a JavaScript file and checked
that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message