mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62742: Handled discarded case in launch nested container handler.
Date Tue, 03 Oct 2017 23:34:31 GMT


> On Oct. 3, 2017, 4:46 p.m., Zhitao Li wrote:
> > src/slave/http.cpp
> > Lines 2408-2409 (original), 2408-2409 (patched)
> > <https://reviews.apache.org/r/62742/diff/1/?file=1842688#file1842688line2408>
> >
> >     It seems like this TODO has already been addressed? Is there still a condition
which we need it?

No, the TODO is not addressed.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62742/#review186963
-----------------------------------------------------------


On Oct. 3, 2017, 4 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62742/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2017, 4 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Zhitao Li.
> 
> 
> Bugs: MESOS-8039
>     https://issues.apache.org/jira/browse/MESOS-8039
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, only the failure case is handled. This patch fix the issue
> by handling discarded case as well.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce 
> 
> 
> Diff: https://reviews.apache.org/r/62742/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message