mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 62740: Fixed using `FindOpenSSL` on Windows.
Date Mon, 02 Oct 2017 23:46:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62740/
-----------------------------------------------------------

Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
-------

Specifically we now forward all possible hints to `FindOpenSSL` to the
`libevent` and `curl` libraries, as they need to use SSL in the same
configured manner. Furthermore, we explicitly always set `curl` to
enable or disable its use of OpenSSL based on our use, as otherwise it
may detect an OpenSSL installation and cause conflicts (this is the same
as we already do for `libevent`.

We also prefer the multi-threaded version of OpenSSL on Windows.


Diffs
-----

  3rdparty/CMakeLists.txt 4e10631cff801f19b191e18528900087d8177a1e 
  cmake/CompilationConfigure.cmake a94cfa14e4eeb727b384d76b8edd41ab3eb97833 


Diff: https://reviews.apache.org/r/62740/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message