Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4B7B4200D01 for ; Fri, 22 Sep 2017 21:05:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A0311609D0; Fri, 22 Sep 2017 19:05:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FD311609BE for ; Fri, 22 Sep 2017 21:05:11 +0200 (CEST) Received: (qmail 5881 invoked by uid 500); 22 Sep 2017 19:05:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5864 invoked by uid 99); 22 Sep 2017 19:05:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 19:05:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E6D76D816B; Fri, 22 Sep 2017 19:05:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pY116R5NSbDd; Fri, 22 Sep 2017 19:05:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 906D361127; Fri, 22 Sep 2017 19:05:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 279CBE0288; Fri, 22 Sep 2017 19:05:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0FA20C402D7; Fri, 22 Sep 2017 19:05:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3285785959619057068==" MIME-Version: 1.0 Subject: Re: Review Request 62502: Added PUBLISH and UNPUBLISH events. From: Chun-Hung Hsiao To: Benjamin Bannier , Jie Yu , Chun-Hung Hsiao Cc: Jan Schlicht , mesos Date: Fri, 22 Sep 2017 19:05:08 -0000 Message-ID: <20170922190508.9074.26348@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62502/ X-Sender: Chun-Hung Hsiao References: <20170922112613.9074.29994@reviews-vm2.apache.org> In-Reply-To: <20170922112613.9074.29994@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos archived-at: Fri, 22 Sep 2017 19:05:12 -0000 --===============3285785959619057068== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62502/#review186007 ----------------------------------------------------------- include/mesos/resource_provider/resource_provider.proto Lines 56 (patched) Can you elaborate the needs of `uuid` and `framework_id`? - Chun-Hung Hsiao On Sept. 22, 2017, 11:26 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62502/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 11:26 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Before launching a task that use resource provider resources, the Mesos > master will instruct the resource provider to make these resources > available for the task. Also the resource provider will checkpoint > informations to be able to reconcile resource usage in case of a > failover. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845 > include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c > src/resource_provider/storage/provider.cpp 46224997430ac0c568904d80014166a6f059907f > src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c > > > Diff: https://reviews.apache.org/r/62502/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > > --===============3285785959619057068==--