Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0FE9200D08 for ; Thu, 21 Sep 2017 13:25:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF8B81609D0; Thu, 21 Sep 2017 11:25:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 419011609B8 for ; Thu, 21 Sep 2017 13:25:47 +0200 (CEST) Received: (qmail 72454 invoked by uid 500); 21 Sep 2017 11:25:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72443 invoked by uid 99); 21 Sep 2017 11:25:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 11:25:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CA03018DFCB for ; Thu, 21 Sep 2017 11:25:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MzZzK4adlEWd for ; Thu, 21 Sep 2017 11:25:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E93CD6105F for ; Thu, 21 Sep 2017 11:25:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 49369E0295; Thu, 21 Sep 2017 11:25:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3425DC4086C; Thu, 21 Sep 2017 11:25:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1406907817904143591==" MIME-Version: 1.0 Subject: Re: Review Request 60057: Made explicit that we dispatch to a process manager. From: Mesos Reviewbot Windows To: Michael Park Cc: Benjamin Bannier , Mesos Reviewbot Windows , mesos Date: Thu, 21 Sep 2017 11:25:37 -0000 Message-ID: <20170921112537.39978.24445@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60057/ X-Sender: Mesos Reviewbot Windows References: <20170921092652.39943.62927@reviews-vm2.apache.org> In-Reply-To: <20170921092652.39943.62927@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos archived-at: Thu, 21 Sep 2017 11:25:48 -0000 --===============1406907817904143591== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60057/#review185877 ----------------------------------------------------------- PASS: Mesos patch 60057 was successfully built and tested. Reviews applied: `['60057']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60057 - Mesos Reviewbot Windows On Sept. 21, 2017, 9:26 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60057/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 9:26 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > This member function of 'ProcessManager' was capturing a 'this' > pointer when dispatching to itself, but did not properly use 'defer' > or 'dispatch'. While this pattern is usually suspect, it was safe here > as we can be sure that the process manager lives long enough to safely > invoke the created callback. > > This patch removes the capture of 'this' and instead explicitly > references the 'static process_manager' in the created callback to > signal that we rely on external invariants. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 7aba8f0117d8a336f39f26a82524aae174306d7f > > > Diff: https://reviews.apache.org/r/60057/diff/3/ > > > Testing > ------- > > * `make check` (Fedora 25 clang-trunk w/ optimizations) > > > Thanks, > > Benjamin Bannier > > --===============1406907817904143591==--