Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26AAB200D09 for ; Tue, 12 Sep 2017 21:47:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2529D1609C7; Tue, 12 Sep 2017 19:47:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6BA381609B4 for ; Tue, 12 Sep 2017 21:47:08 +0200 (CEST) Received: (qmail 33658 invoked by uid 500); 12 Sep 2017 19:47:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33647 invoked by uid 99); 12 Sep 2017 19:47:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Sep 2017 19:47:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D59A0183E29; Tue, 12 Sep 2017 19:47:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hnv8Ipc4NAaT; Tue, 12 Sep 2017 19:47:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1E2DB5FB2E; Tue, 12 Sep 2017 19:47:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 79802E01D8; Tue, 12 Sep 2017 19:47:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5FBCDC40461; Tue, 12 Sep 2017 19:47:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7542366161847620160==" MIME-Version: 1.0 Subject: Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. From: =?utf-8?q?Gast=C3=B3n_Kleiman?= To: Benjamin Bannier , Joerg Schad , Greg Mann Cc: Mesos Reviewbot Windows , mesos , =?utf-8?q?Gast=C3=B3n_Kleiman?= Date: Tue, 12 Sep 2017 19:47:04 -0000 Message-ID: <20170912194704.46133.15577@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?=@reviews.apache.org, =?utf-8?q?=3E?=@reviews.apache.org X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62197/ X-Sender: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cnoreply=40reviews=2Eapache=2Eorg?= =?utf-8?q?=3E?= References: <20170909065217.25266.70039@reviews-vm2.apache.org> In-Reply-To: <20170909065217.25266.70039@reviews-vm2.apache.org> Reply-To: =?utf-8?q?Gast=C3=B3n_Kleiman_=3Cgaston=40mesosphere=2Eio=3E?=@reviews.apache.org X-ReviewRequest-Repository: mesos archived-at: Tue, 12 Sep 2017 19:47:09 -0000 --===============7542366161847620160== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ ----------------------------------------------------------- (Updated Sept. 12, 2017, 7:47 p.m.) Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad. Changes ------- Removed unused methods + used `createCommandInfo` helper. Bugs: MESOS-7877 https://issues.apache.org/jira/browse/MESOS-7877 Repository: mesos Description ------- These new overloads make it possible to specify a framework ID, executor resources as a proto, and the executor ID also as a proto. Diffs (updated) ----- src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 Diff: https://reviews.apache.org/r/62197/diff/4/ Changes: https://reviews.apache.org/r/62197/diff/3-4/ Testing ------- `make check` still passes on GNU/Linux. Thanks, Gastón Kleiman --===============7542366161847620160==--