Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6346230193113077826=="
MIME-Version: 1.0
Subject: Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows
 and associated tests.
From: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
To: Jeff Coffler <jeff@taltos.com>, Joseph Wu <joseph@mesosphere.io>,
 Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Cc: John Kordich <johnkord@microsoft.com>, mesos <reviews@mesos.apache.org>
Date: Thu, 07 Sep 2017 23:17:24 -0000
Message-ID: <20170907231724.39549.68121@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Andrew Schwartzmeyer <noreply@reviews.apache.org>
References: <20170907011111.26227.77856@reviews-vm2.apache.org>
In-Reply-To: <20170907011111.26227.77856@reviews-vm2.apache.org>
Reply-To: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
archived-at: Thu, 07 Sep 2017 23:21:48 -0000

--===============6346230193113077826==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184911
-----------------------------------------------------------


cmake/CompilationConfigure.cmake
Lines 109-112 (original), 109-112 (patched)
<https://reviews.apache.org/r/62106/#comment261108>

    It occurred to me that if we're assuming authentication support is univesally available (now true on Windows since it's bundled, and is already assumed to be true elsewhere), we should delete this entire option and make sure it's not used anywhere.


- Andrew Schwartzmeyer


On Sept. 6, 2017, 6:11 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 6:11 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled CRAM MD5 Authentication on Windows and associated tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 
>   docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f 
>   src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 
>   src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5 
>   src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c 
>   src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 
>   support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef 
> 
> 
> Diff: https://reviews.apache.org/r/62106/diff/3/
> 
> 
> Testing
> -------
> 
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors.  Ran tests on both platforms as well.  Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos)
> 
> 
> Thanks,
> 
> John Kordich
> 
>


--===============6346230193113077826==--