Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 02DD4200CFD for ; Wed, 6 Sep 2017 14:12:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 014331609DB; Wed, 6 Sep 2017 12:12:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47A391609B8 for ; Wed, 6 Sep 2017 14:12:28 +0200 (CEST) Received: (qmail 49727 invoked by uid 500); 6 Sep 2017 12:12:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49716 invoked by uid 99); 6 Sep 2017 12:12:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 12:12:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6AA71183D67; Wed, 6 Sep 2017 12:12:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mqnoYesw2_9M; Wed, 6 Sep 2017 12:12:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C5DC15FD33; Wed, 6 Sep 2017 12:12:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6309EE010F; Wed, 6 Sep 2017 12:12:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BF28BC41654; Wed, 6 Sep 2017 12:12:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7049297230638525023==" MIME-Version: 1.0 Subject: Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics. From: Mesos Reviewbot Windows To: Chun-Hung Hsiao , Joseph Wu Cc: Mesos Reviewbot Windows , Alexander Rukletsov , mesos Date: Wed, 06 Sep 2017 12:12:21 -0000 Message-ID: <20170906121221.26227.80048@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62116/ X-Sender: Mesos Reviewbot Windows References: <20170906100304.26308.31952@reviews-vm2.apache.org> In-Reply-To: <20170906100304.26308.31952@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos archived-at: Wed, 06 Sep 2017 12:12:29 -0000 --===============7049297230638525023== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/#review184656 ----------------------------------------------------------- FAIL: Mesos tests failed to run Reviews applied: [62116] Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62116/logs - Mesos Reviewbot Windows On Sept. 6, 2017, 10:03 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62116/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 10:03 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Some example frameworks consider all TASK_LOST updates as a sign of > an abnormal termination. However, the task can fail to run due to > the offer becoming invalid, which is inherently racy and does not > mean the task has terminated abnormally. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 > src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 > src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 > > > Diff: https://reviews.apache.org/r/62116/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > > --===============7049297230638525023==--