Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5DD4A200CFD for ; Wed, 6 Sep 2017 11:46:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C5D4161198; Wed, 6 Sep 2017 09:46:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A1DDC160CD8 for ; Wed, 6 Sep 2017 11:46:07 +0200 (CEST) Received: (qmail 95085 invoked by uid 500); 6 Sep 2017 09:46:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 95068 invoked by uid 99); 6 Sep 2017 09:46:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 09:46:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 14E6F1A59E2; Wed, 6 Sep 2017 09:46:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OGkACeB0GncO; Wed, 6 Sep 2017 09:46:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E766E5FDA1; Wed, 6 Sep 2017 09:46:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AE6E2E0373; Wed, 6 Sep 2017 09:46:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 994F2C41654; Wed, 6 Sep 2017 09:46:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1996578031457363834==" MIME-Version: 1.0 Subject: Review Request 62115: Fix stout build with newer boost versions. From: Benno Evers To: Benno Evers , mesos Date: Wed, 06 Sep 2017 09:46:03 -0000 Message-ID: <20170906094603.26264.51256@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62115/ X-Sender: Benno Evers Reply-To: Benno Evers X-ReviewRequest-Repository: mesos archived-at: Wed, 06 Sep 2017 09:46:08 -0000 --===============1996578031457363834== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ ----------------------------------------------------------- Review request for mesos. Repository: mesos Description ------- Starting from Boost 1.62, Boost.Variant added additional compile-time checks to its constructors to fix this issue: https://svn.boost.org/trac10/ticket/11602 However, this breaks some places in stout which try to access a derived class from a variant holding the base class. Diffs ----- 3rdparty/stout/include/stout/json.hpp 4f9ea1b34537026af80edd97fa0b3ae1a3dfa862 3rdparty/stout/include/stout/protobuf.hpp 15690b66cc4ae0c1bf2c2176d73c385ca75d3c20 3rdparty/stout/tests/json_tests.cpp adaa343faf3b557ad483675318b22eb90b1eeb52 Diff: https://reviews.apache.org/r/62115/diff/1/ Testing ------- Thanks, Benno Evers --===============1996578031457363834==--