Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C1499200CF6 for ; Sun, 3 Sep 2017 16:31:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BFF6E164396; Sun, 3 Sep 2017 14:31:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18A0D164397 for ; Sun, 3 Sep 2017 16:31:51 +0200 (CEST) Received: (qmail 21010 invoked by uid 500); 3 Sep 2017 14:31:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20660 invoked by uid 99); 3 Sep 2017 14:31:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Sep 2017 14:31:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B08C3182FBA; Sun, 3 Sep 2017 14:31:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tCxQzYsJKYYz; Sun, 3 Sep 2017 14:31:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D3C715F6C8; Sun, 3 Sep 2017 14:31:42 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 23958E002C; Sun, 3 Sep 2017 14:31:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2D720C415E4; Sun, 3 Sep 2017 14:31:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7044647428641748263==" MIME-Version: 1.0 Subject: Re: Review Request 61210: Renamed constants for CLI tests. From: Mesos Reviewbot To: Kevin Klues Cc: Mesos Reviewbot , Armand Grillet , mesos Date: Sun, 03 Sep 2017 14:31:39 -0000 Message-ID: <20170903143139.27115.25008@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61210/ X-Sender: Mesos Reviewbot References: <20170903083438.27082.21189@reviews-vm2.apache.org> In-Reply-To: <20170903083438.27082.21189@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos archived-at: Sun, 03 Sep 2017 14:31:52 -0000 --===============7044647428641748263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61210/#review184469 ----------------------------------------------------------- Patch looks great! Reviews applied: [61210] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 3, 2017, 8:34 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61210/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2017, 8:34 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7840 > https://issues.apache.org/jira/browse/MESOS-7840 > > > Repository: mesos > > > Description > ------- > > These constants are now prefixed by 'TEST' instead of 'DEFAULT'. > > > Diffs > ----- > > src/python/cli_new/lib/cli/tests/base.py 1101aef79d0d99c0c6e69296adf622891897e5bc > src/python/cli_new/lib/cli/tests/constants.py 5d45d94c9274cb9c16820da2d3314265345df1c6 > > > Diff: https://reviews.apache.org/r/61210/diff/2/ > > > Testing > ------- > > ``` > $ ./bootstrap > $ source activate > $ mesos-cli-tests > ``` > > I also checked that the Python linter was still working. > > > Thanks, > > Armand Grillet > > --===============7044647428641748263==--