mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.
Date Tue, 26 Sep 2017 20:14:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/
-----------------------------------------------------------

(Updated Sept. 26, 2017, 8:14 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Changes
-------

Fix scope of the common function.


Bugs: MESOS-6894
    https://issues.apache.org/jira/browse/MESOS-6894


Repository: mesos


Description
-------

These tests were using a `TaskInfo` field which is missing required
protobuf fields. After the previous patch begins to checkpoint
`ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
thus caused these tests to fail.

This patch backfills these fields to make these tests pass.


Diffs (updated)
-----

  src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee



Diff: https://reviews.apache.org/r/55335/diff/6/

Changes: https://reviews.apache.org/r/55335/diff/5-6/


Testing
-------

GTEST_FILTER="MesosContainerizer*" make check


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message