mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 62481: Fixed tests impacted by no longer removing the agent symlink.
Date Tue, 26 Sep 2017 18:58:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186310
-----------------------------------------------------------




src/tests/gc_tests.cpp
Line 381 (original)
<https://reviews.apache.org/r/62481/#comment262804>

    I think we should wait until `__recover` gets executed to be sure that no gc has been
scheduled.


- Vinod Kone


On Sept. 26, 2017, 4:59 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 4:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7445
>     https://issues.apache.org/jira/browse/MESOS-7445
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
> 
> Review: https://reviews.apache.org/r/62481
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d 
>   src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
>   src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
> 
> 
> Diff: https://reviews.apache.org/r/62481/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message