mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 61210: Renamed constants for CLI tests.
Date Fri, 22 Sep 2017 13:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61210/#review185983
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Sept. 3, 2017, 8:34 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61210/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2017, 8:34 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7840
>     https://issues.apache.org/jira/browse/MESOS-7840
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These constants are now prefixed by 'TEST' instead of 'DEFAULT'.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/tests/base.py 1101aef79d0d99c0c6e69296adf622891897e5bc 
>   src/python/cli_new/lib/cli/tests/constants.py 5d45d94c9274cb9c16820da2d3314265345df1c6

> 
> 
> Diff: https://reviews.apache.org/r/61210/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
> 
> I also checked that the Python linter was still working.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message