mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62447: Revert usage of `-isystem` flag.
Date Thu, 21 Sep 2017 10:31:49 GMT


> On Sept. 21, 2017, 10:34 a.m., Benjamin Bannier wrote:
> > configure.ac
> > Line 754 (original), 754 (patched)
> > <https://reviews.apache.org/r/62447/diff/1/?file=1831601#file1831601line754>
> >
> >     Could you also update the cmake build? It currently does not support unbundling
most dependencies, but we should prevent the same bug from occuring there as well. Look for
3rdparty `target_include_directories` with `INTERFACE` property (`INTERFACE` needs to be removed),
e.g.,
> >     
> >       https://github.com/apache/mesos/blob/11de04c1bbf65d0a90576642f8ea9574e05a317a/3rdparty/CMakeLists.txt#L159
> 
> Benno Evers wrote:
>     When you say `INTERFACE`, do you mean `SYSTEM`?

Yes, of course. Sorry for the confusion.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review185855
-----------------------------------------------------------


On Sept. 20, 2017, 7:08 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 7:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -----
> 
>   configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
> 
> 
> Diff: https://reviews.apache.org/r/62447/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message