mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.
Date Mon, 18 Sep 2017 19:43:38 GMT


> On Sept. 18, 2017, 12:42 p.m., Andrew Schwartzmeyer wrote:
> > src/master/master.cpp
> > Lines 494-605 (original), 494-587 (patched)
> > <https://reviews.apache.org/r/62106/diff/4/?file=1818635#file1818635line494>
> >
> >     I believe this to be fine, and I briefly checked with Jie (I think) at MesosCon
about this, but I'd like to make sure we get one more reviewer to make 100% sure we can remove
the `HAS_AUTHENTICATION` definition. I'll get them added...

I can't edit your review. John, would you add Jie Yu as a reviewer?


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review185614
-----------------------------------------------------------


On Sept. 8, 2017, 3:13 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2017, 3:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled CRAM MD5 Authentication on Windows and associated tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 
>   docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242 
>   docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f 
>   src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 
>   src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b 
>   src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5

>   src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c

>   src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb 
>   src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce 
>   src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 
>   src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 
>   src/tests/mesos.cpp fc7f8cb09e223000ea160aa4ab83a003cf4af2fb 
>   support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef 
> 
> 
> Diff: https://reviews.apache.org/r/62106/diff/4/
> 
> 
> Testing
> -------
> 
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows,
with no errors.  Ran tests on both platforms as well.  Note: The mesos-3rdparty pull request
which contains the cyrus-sasl package needs to be merged to master first before these patches
will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured
with mesos)
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message