mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 62381: Removed `docker exec` when performing health checks in docker executor.
Date Mon, 18 Sep 2017 12:27:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent huang, and Lukas
Loesche.


Bugs: MESOS-4812
    https://issues.apache.org/jira/browse/MESOS-4812


Repository: mesos


Description
-------

Mesos can enter namespaces via `setns` for launched subprocesses, hence
we got rid of `docker exec` for command health checks. This change
leads to more stable command health checks by making them independent
from docker daemon that might hang. Also, this commit fixes the issue
with incorrect escaping of quote characters in command health checks.


Diffs
-----

  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 


Diff: https://reviews.apache.org/r/62381/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message