mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.
Date Tue, 12 Sep 2017 19:47:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62197/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 7:47 p.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad.


Changes
-------

Removed unused methods + used `createCommandInfo` helper.


Bugs: MESOS-7877
    https://issues.apache.org/jira/browse/MESOS-7877


Repository: mesos


Description
-------

These new overloads make it possible to specify a framework ID, executor
resources as a proto, and the executor ID also as a proto.


Diffs (updated)
-----

  src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 


Diff: https://reviews.apache.org/r/62197/diff/4/

Changes: https://reviews.apache.org/r/62197/diff/3-4/


Testing
-------

`make check` still passes on GNU/Linux.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message