mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62040: Also log attached path in agent.
Date Wed, 06 Sep 2017 20:57:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62040/#review184732
-----------------------------------------------------------



Looks good! Just a few minor items to take care of.


src/slave/slave.hpp
Lines 377-378 (original), 377-379 (patched)
<https://reviews.apache.org/r/62040/#comment260926>

    How about path and virtualPath here and "virtual path" in the logging? We probably should
have picked these names in the files API as well, feel free to make that change there if you
like.



src/slave/slave.cpp
Lines 807 (patched)
<https://reviews.apache.org/r/62040/#comment260927>

    SLAVE_LOG_VIRTUAL_PATH
    
    Do you want to pull this up into slave/constants.hpp so that others can read it?



src/slave/slave.cpp
Line 940 (original), 947 (patched)
<https://reviews.apache.org/r/62040/#comment260928>

    How about:
    
    Successfully attached '/foo/bar' to virtual path '/bar'
    
    We said "file" but this can be a directory too, so maybe let's say "path" or nothing?


- Benjamin Mahler


On Sept. 1, 2017, 10:53 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62040/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 10:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jason Lai.
> 
> 
> Bugs: MESOS-7899
>     https://issues.apache.org/jira/browse/MESOS-7899
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The same physical directory will be mounted to multiple logical paths,
> so we also log the logical path in agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 
>   src/slave/slave.cpp df920ec07cd59c7ba6baccfc1c20ed3809f187d6 
> 
> 
> Diff: https://reviews.apache.org/r/62040/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message