mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62113: Fixed compilation issue on Mac OS.
Date Wed, 06 Sep 2017 16:06:30 GMT


> On Sept. 6, 2017, 8:32 a.m., Jan Schlicht wrote:
> > src/tests/CMakeLists.txt
> > Lines 224 (patched)
> > <https://reviews.apache.org/r/62113/diff/1/?file=1816139#file1816139line225>
> >
> >     See above.

sorry guys, will fix this.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62113/#review184635
-----------------------------------------------------------


On Sept. 6, 2017, 8:20 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62113/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 8:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Commit 6f98b8d6d149c5497d16f588c683a68fccba4fc9 has moved a linux-only
> tests to a test file that compiles on non-linux machines. This change
> demotes "volume_sandbox_path_isolator_tests.cpp" to be linux-only.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
> 
> 
> Diff: https://reviews.apache.org/r/62113/diff/1/
> 
> 
> Testing
> -------
> 
> make check on Mac OS
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message