mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60593: Added `network/ports` isolator recovery tests.
Date Wed, 06 Sep 2017 12:19:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review184657
-----------------------------------------------------------




src/tests/containerizer/ports_isolator_tests.cpp
Lines 704-706 (patched)
<https://reviews.apache.org/r/60593/#comment260845>

    These 3 lines can be merged into 2 lines.



src/tests/containerizer/ports_isolator_tests.cpp
Lines 741 (patched)
<https://reviews.apache.org/r/60593/#comment260848>

    Why do we need to explicitly set this flag to such a large number?


- Qian Zhang


On Aug. 31, 2017, 8:08 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 8:08 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60593/diff/14/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message