mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <ben...@yandex-team.ru>
Subject Review Request 62115: Fix stout build with newer boost versions.
Date Wed, 06 Sep 2017 09:46:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62115/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Starting from Boost 1.62, Boost.Variant added additional
compile-time checks to its constructors to fix this
issue: https://svn.boost.org/trac10/ticket/11602

However, this breaks some places in stout which try
to access a derived class from a variant holding the
base class.


Diffs
-----

  3rdparty/stout/include/stout/json.hpp 4f9ea1b34537026af80edd97fa0b3ae1a3dfa862 
  3rdparty/stout/include/stout/protobuf.hpp 15690b66cc4ae0c1bf2c2176d73c385ca75d3c20 
  3rdparty/stout/tests/json_tests.cpp adaa343faf3b557ad483675318b22eb90b1eeb52 


Diff: https://reviews.apache.org/r/62115/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message