mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61343: Supported finding the correct subversion libraries on macOS.
Date Sat, 02 Sep 2017 15:15:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61343/#review184426
-----------------------------------------------------------


Ship it!




Mirrors logic in FindApr.cmake.


3rdparty/stout/cmake/FindSvn.cmake
Lines 19-22 (patched)
<https://reviews.apache.org/r/61343/#comment260603>

    Going to add:
    ```
    # NOTE: If this fails, stderr is ignored, and the output variable is empty.
    # This has no deleterious effect on our path search.
    ```


- Joseph Wu


On Aug. 1, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61343/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This prefers the `brew` subversion package on macOS over the system
> libraries.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/FindSvn.cmake 63aff9d91041edc861a655562f085e50f7d1e881 
> 
> 
> Diff: https://reviews.apache.org/r/61343/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message